Code cleanup: Replaced 'idx' with '_'. Removed unused parameter & unused import#59
Open
faeezshaikh wants to merge 3 commits intotwitter:mainfrom
Open
Code cleanup: Replaced 'idx' with '_'. Removed unused parameter & unused import#59faeezshaikh wants to merge 3 commits intotwitter:mainfrom
faeezshaikh wants to merge 3 commits intotwitter:mainfrom
Conversation
added 2 commits
April 1, 2023 16:14
|
Faeez Shaikh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
idxvariable is not used in the code after it is defined, so it can be removed without affecting the behavior of the code. Theidxshould be replaced with_. This will indicate that the loop variable is not used, while still iterating overnum_examplestimes.Removed unused parameter from the get_readers(). The
num_readers_per_worker parameteris not being used inside theget_readersfunction, and it appears to be an unused parameter. The function creates one reader per worker, sonum_readers_per_workerdoes not seem to have any effect on the behavior of the function. It's possible that this parameter was intended to be used in some way but was later removed or overlooked. Therefore,num_readers_per_workerappears to be an unnecessary parameter and can be removed from the function signature.Removed unused import
LocalFileSystem.LocalFileSystemfromfsspec.implementations.localis imported but not used in the code.