Bug in SpecificDiscoveryStore breaks PubSub communication#294
Draft
KonradBreitsprecherBkd wants to merge 2 commits intomainfrom
Draft
Bug in SpecificDiscoveryStore breaks PubSub communication#294KonradBreitsprecherBkd wants to merge 2 commits intomainfrom
KonradBreitsprecherBkd wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a specific setup, the PubSub communication is failing. Minimal conditions to reproduce the bug are:
L1L1and the optional labelL2The bug can be traced back to the
SpecificDiscoveryStore. This is the lookup algorithm that is supposed to improve the matching of publishers and subscribers with labels.