added public StrongName signing for Release build configuration#18
added public StrongName signing for Release build configuration#180x6d61726b wants to merge 3 commits intoygoe:masterfrom
Conversation
|
To be honest, I don't know what strong name signing is. Never used it, never needed it. Does it even still exist in the newer .NET Core/5 series? Your change seems to introduce private key material. Is that a good idea in a (public) code repository? |
|
Hello Yves, please have a look to the following links (which I hope explains the topic):
Two examples of other open source projects using strong name signing: |
Actually I don't think anything here. I'd just follow your suggestion. It looks plausible in its current form. If you'd prefer to also sign debug builds, please change the PR to not include that line. Otherwise, I'd merge it as-is. |
|
I have enabled Strong Name signing globally and merged latest changes from master. |
Added public StrongName signing for Release build configuration, so the NetRevisionTask.dll can be called by strong named assemblies.
If you think signing of Debug builds is also a good idea, the following line can simply be removed:
<SignAssembly>false</SignAssembly>