Trim decimals #156

samdark · 2026-01-08T20:24:02Z

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌

Copilot

Pull request overview

This PR adds a new NumericHelper::trimDecimalZeros() method that removes trailing zeros from the decimal part of numeric strings. The implementation handles various edge cases including null values, empty strings, negative numbers, and numbers without decimal parts.

Adds trimDecimalZeros() static method to NumericHelper class
Includes comprehensive test coverage with 10 test cases
Updates documentation comment style for existing method

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/NumericHelper.php	Adds the new `trimDecimalZeros()` method with documentation, also fixes hyphenation in existing docblock
tests/NumericHelperTest.php	Adds test data provider and test method for the new functionality
CHANGELOG.md	Documents the new feature in the 2.7.1 release notes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/NumericHelperTest.php

src/NumericHelper.php

tests/NumericHelperTest.php

Co-authored-by: Copilot <[email protected]>

Copilot · 2026-01-08T20:47:46Z

@samdark I've opened a new pull request, #157, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-08T20:47:56Z

@samdark I've opened a new pull request, #158, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: samdark <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]>

src/NumericHelper.php

Co-authored-by: Sergei Tigrov <[email protected]>

@return

diff --git c/src/NumericHelper.php i/src/NumericHelper.php index c602ede..2506fde 100644 --- c/src/NumericHelper.php +++ i/src/NumericHelper.php @@ -16,9 +16,6 @@ use function is_numeric; use function is_scalar; use function preg_match; use function preg_replace; -use function rtrim; -use function str_contains; -use function str_ends_with; use function str_replace; use function substr; @@ -176,7 +173,7 @@ final class NumericHelper * containing a decimal part. * * @return string|null The input string with trailing decimal zeros (and a trailing decimal - * separator, if any) removed, or `null` if the input was `null`. + * separator, if any) removed, or `null` if the input was `null` or an empty string. */ public static function trimDecimalZeros(?string $value): ?string {

diff --git c/src/NumericHelper.php i/src/NumericHelper.php index 2506fde..d1c388b 100644 --- c/src/NumericHelper.php +++ i/src/NumericHelper.php @@ -186,16 +186,26 @@ final class NumericHelper return null; } - if (!str_contains($value, '.')) { - return $value; - } - /** @psalm-suppress PossiblyNullArgument */ - $value = rtrim($value, '0'); - - if (!str_ends_with($value, '.')) { + $decimalPosition = strpos($value, '.'); + if ($decimalPosition === false) { return $value; } - return substr($value, 0, -1); + $length = strlen($value); + $index = $length - 1; + + while ($index > $decimalPosition && $value[$index] === '0') { + $index--; + } + + if ($index === $length - 1) { + return $value; + } + + if ($index === $decimalPosition) { + return substr($value, 0, $decimalPosition); + } + + return substr($value, 0, $index + 1); } }

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

src/NumericHelper.php

vjik · 2026-01-13T06:44:29Z

src/NumericHelper.php

+            return $value;
+        }
+
+        return substr($value, 0, -1);


Check on empty string, and return null when it is empty string.

It cannot be empty here
see https://github.com/yiisoft/strings/pull/156/changes#diff-15ef64234a820b0afaa4ae1f2a2973f6d55ea12f779834d01ee7fce6b90f7609R189

Seems, for string ".000" result will be empty string.

Should it be in some cases 0, instead of null for empty result?

Good question. I don't know.

empty string => "0" or null ? string with spaces only => "0" or null ? "." => "0" or null?

I think we should choose between two options:

null => null empty string => null string with spaces only => null "." => null ".00" => null

null => null empty string => "0" string with spaces only => "0" "." => "0" ".00" => "0"

Implemented.

This is unexpected:

"." => null ".00" => '0'

What is difference between "." and ".00" ?

.5 or .0 is still a common notation for a number. . is... well, something weird.

What if . 00 (extra space after dot)?
Currently it will return . (dot and space).

Hmm... yes. That made me think if we should attempt to normalize the number, and it seems we should not. It's a method to trim decimals.

Adjusted tests and code.

Co-authored-by: Sergei Predvoditelev <[email protected]>

Trim decimals

be2294f

samdark requested review from a team and Copilot January 8, 2026 20:24

Add CHANGELOG number

cad1804

Copilot started reviewing on behalf of samdark January 8, 2026 20:24 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

tests/NumericHelperTest.php Outdated Show resolved Hide resolved

src/NumericHelper.php Show resolved Hide resolved

tests/NumericHelperTest.php Outdated Show resolved Hide resolved

tests/NumericHelperTest.php Outdated Show resolved Hide resolved

Update tests/NumericHelperTest.php

2372b81

Co-authored-by: Copilot <[email protected]>

This was referenced Jan 8, 2026

Add missing use function imports in NumericHelper #157

Merged

Rename data provider to follow naming convention #158

Merged

Copilot AI and others added 2 commits January 9, 2026 01:03

Rename data provider to follow naming convention (#158)

8cc129a

Co-authored-by: samdark <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Add missing use function imports in NumericHelper (#157)

b46f55b

Co-authored-by: samdark <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]>

vjik reviewed Jan 9, 2026

View reviewed changes

src/NumericHelper.php Show resolved Hide resolved

Tigrov reviewed Jan 9, 2026

View reviewed changes

src/NumericHelper.php Outdated Show resolved Hide resolved

samdark and others added 6 commits January 11, 2026 14:10

Update src/NumericHelper.php

408811e

Co-authored-by: Sergei Tigrov <[email protected]>

Return null for empty string

85223ac

Add benchmark

76b057e

Choose more readable code

4576748

samdark requested review from Tigrov, Copilot and vjik January 13, 2026 00:25

samdark added the status:code review The pull request needs review. label Jan 13, 2026

Copilot AI reviewed Jan 13, 2026

View reviewed changes

vjik requested changes Jan 13, 2026

View reviewed changes

samdark and others added 3 commits January 14, 2026 10:34

Update src/NumericHelper.php

aa39acb

Co-authored-by: Sergei Predvoditelev <[email protected]>

Handle edge cases

da589d5

Adjust tests and code

3a4fcf6

samdark added 3 commits January 16, 2026 11:31

Add edge case test

3ce77f6

Handle edge case

db2011c

Fix edge case

591ffc1

Uh oh!

Trim decimals #156

Are you sure you want to change the base?

Trim decimals #156

Conversation

samdark commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 8, 2026

Uh oh!

Copilot AI commented Jan 8, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants