⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@vitallium
Copy link
Collaborator

Re-add basic CI workflow back:

  • Configure Rust for all platforms: Win, Linux and macOS.
  • Run formatter
  • Run linter (clippy)
  • Run tests via nextest

@cla-bot cla-bot bot added the cla-signed label Jan 25, 2026
@vitallium vitallium force-pushed the vs/add-ci-tests-back branch 2 times, most recently from c729ed1 to 22f0d1a Compare January 25, 2026 09:59
@vitallium vitallium force-pushed the vs/add-ci-tests-back branch from 22f0d1a to c33d7eb Compare January 25, 2026 10:01
@vitallium
Copy link
Collaborator Author

@MrSubidubi Hey! I'd like to double-check that it's fine to add this basic CI workflow back. Happy to hear your thoughts. Thanks!

@MrSubidubi
Copy link
Contributor

MrSubidubi commented Jan 26, 2026

First of all, sorry for the run_tests being gone some time earlier, that was a mistake on our end, pinged our security guy and that is fixed again.

Not against merging this, before we do though, I'd like to know as to what of these things we'd actually want upstream and what not. Formatting we do have and I am in no way about enforcing more clippy lints, so yeah, would like to know what we can improve upstream and what you think is best just for your purposes here.

@vitallium
Copy link
Collaborator Author

First of all, sorry for the run_tests being gone some time earlier, that was a mistake on our end, pinged our security guy and that is fixed again.

@MrSubidubi Thanks for that! I can see the run_tests job now.

Not against merging this, before we do though, I'd like to know as to what of these things we'd actually want upstream and what not. Formatting we do have and I am in no way about enforcing more clippy lints, so yeah, would like to know what we can improve upstream and what you think is best just for your purposes here.

I think run_tests is enough for this case. Testing tree-sitter queries is done via cargo test, and run_tests also uses nextest, so we’re good here. Thanks for the help!

@vitallium vitallium closed this Jan 26, 2026
@MrSubidubi
Copy link
Contributor

My pleasure! Apologies for the disruption, that only happened because we were finally able to roll out the changes to the entire org (we had some whitelisted extensions that needed special attention and were finally ready to empty that list) 🎉

And by emptying the whitelist, GitHub changed the policy to apply to no extensions at all....

Now though, given that the rollout happened in it's entirety, this should (hopefully) never happen again. If it does anyway (which I really think it won't), feel free to ping me. Thanks!

@vitallium
Copy link
Collaborator Author

It seems we are hitting CI timeouts (3 minutes) configured here https://github.com/zed-industries/zed/blob/main/.github/workflows/extension_tests.yml#L77 @MrSubidubi is there a way to increase it? Thanks!

@MrSubidubi
Copy link
Contributor

Will be resolved once zed-industries/zed#47686 is in - that said, would love to know if we can eventually find a way to run the tests faster as opposed to bumping runner size.

@vitallium
Copy link
Collaborator Author

Will be resolved once zed-industries/zed#47686 is in - that said, would love to know if we can eventually find a way to run the tests faster as opposed to bumping runner size.

Awesome, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants