-
Notifications
You must be signed in to change notification settings - Fork 618
[JDBC-V2] fixed the JDBC version in database metadata #2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
approved these changes
Feb 5, 2026
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
com.clickhouse.jdbc.metadata.DatabaseMetaDataImpl#getJDBCMajorVersionandcom.clickhouse.jdbc.metadata.DatabaseMetaDataImpl#getJDBCMinorVersion. Previously was returning driver's version what is wrong. It should return spec supported version. We support 4.2 (what is almost fresh, next is 4.3)Checklist
Delete items not relevant to your PR:
Note
Low Risk
Small, localized metadata change with corresponding test update; only affects clients that read JDBC version from
DatabaseMetaData.Overview
Fixes JDBC version reporting in
DatabaseMetaDataImplsogetJDBCMajorVersion()/getJDBCMinorVersion()return the supported JDBC spec version (4.2) instead of the ClickHouse driver’s own version.Updates the integration test expectations in
DatabaseMetaDataTestto assert the new4/2values.Written by Cursor Bugbot for commit a4bb4a2. This will update automatically on new commits. Configure here.