⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

[JDBC-V2] fixed the JDBC version in database metadata #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chernser merged 1 commit into from
Feb 5, 2026
Merged

[JDBC-V2] fixed the JDBC version in database metadata #2736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
public class DatabaseMetaDataImpl implements java.sql.DatabaseMetaData, JdbcV2Wrapper {
private static final Logger log = LoggerFactory.getLogger(DatabaseMetaDataImpl.class);

private static final int JDBC_SPEC_MAJOR_VERSION = 4;
private static final int JDBC_SPEC_MINOR_VERSION = 2;

public enum TableType {
DICTIONARY("DICTIONARY"),
LOG_TABLE("LOG TABLE"),
Expand Down Expand Up @@ -1410,12 +1413,12 @@ public int getDatabaseMinorVersion() throws SQLException {

@Override
public int getJDBCMajorVersion() throws SQLException {
return Driver.getDriverMajorVersion();
return JDBC_SPEC_MAJOR_VERSION;
}

@Override
public int getJDBCMinorVersion() throws SQLException {
return Driver.getDriverMinorVersion();
return JDBC_SPEC_MINOR_VERSION;
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,8 @@ public void testSupportFlags() throws Exception {
assertEquals(dbmd.supportsMultipleOpenResults(), false);
assertEquals(dbmd.supportsGetGeneratedKeys(), false);
assertEquals(dbmd.getResultSetHoldability(), 1);
assertEquals(dbmd.getJDBCMajorVersion(), 9);
assertEquals(dbmd.getJDBCMinorVersion(), 6);
assertEquals(dbmd.getJDBCMajorVersion(), 4); // Latest major version (since java 6).
assertEquals(dbmd.getJDBCMinorVersion(), 2); // Most supported minor version (since java 8).
assertEquals(dbmd.getSQLStateType(), 2);
assertEquals(dbmd.supportsStatementPooling(), false);
assertEquals(dbmd.getRowIdLifetime(), ROWID_UNSUPPORTED);
Expand Down
Loading