Update ChannelDetails docs for splicing#721
Conversation
This simply adopts the changes of rust-lightning#4250.
|
I've assigned @valentinewallace as a reviewer! |
| /// | ||
| /// [`Node::list_channels`]: crate::Node::list_channels | ||
| #[derive(Debug, Clone)] | ||
| pub struct ChannelDetails { |
There was a problem hiding this comment.
For my understanding of LDK Node, why do we duplicate this struct here vs using the rust-lightning type?
There was a problem hiding this comment.
The reason is mostly bindings, as we don't have a good way to expose all fields on the LDK variant (e.g., InitFeatures, but we also have our own version of config: ChannelConfig as the LDK enum MaxDustHTLCExposure has tuple enum variants which our bindings generator uniffi doesn't support). It's also due to the docs on ChannelDetails referring to LDK APIs that aren't exposed in LDK Node. And, lastly, in LDK Node we also made the decision to not expose LDK's forked OutPoint variant but rather consistently only ever expose bitcoin::OutPoint.
There was a problem hiding this comment.
Ah, got it. Thanks for that explanation!
3 participants
This simply adopts the changes of rust-lightning#4250.